Forms: Hide Google export card if disabled #45375

edanzer · 2025-10-03T20:39:48Z

Proposed changes:

As of this PR, users can filter what integrations are enabled for Jetpack Forms.

In CIAB, we disable most integrations, including Google Drive. We found that when Google Drive is disabled, we still show the Google Drive export card in the forms dashboard, but the export button is a never ending spinner since have a separate check just for the button. This PR uses the new integrations store to check if Google is enabled, and if not, hide that card. It also updates the check on the Export button to use the same store-based check (we could skip this check since the whole card is now hidden).

Before

After

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Test no regressions.

Go to Jetpack > Forms, click the Export button, and export your responses to Google. Everything should work as before.

Test when Google is disabled.

Disable the Google Drive integrations by adding the snippet below.
Go to Jetpack > Forms. Click the Export button in the upper right. Confirm that the Google export card no longer shows in the modal.

add_filter( 'jetpack_forms_supported_integrations', function ( $integrations ) {
  unset( $integrations['google-drive'] ); // Hide Google Drive
  return $integrations;
} );

github-actions · 2025-10-03T20:40:46Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-google-enabled-check branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-google-enabled-check

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-10-03T20:41:02Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: November 4, 2025
- Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-10-03T20:49:10Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/dashboard/components/export-responses-modal/index.tsx	0/7 (0.00%)	0.00%	5 💔
projects/packages/forms/src/dashboard/inbox/export-responses/google-drive.tsx	0/37 (0.00%)	0.00%	4 💔

Full summary · PHP report · JS report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

edanzer · 2025-10-03T20:52:45Z

projects/packages/forms/src/dashboard/inbox/export-responses/google-drive.tsx

+		const list = store.getIntegrations() || [];
+		return { integration: list.find( ( i: Integration ) => i.id === 'google-drive' ) };
+	}, [] ) as { integration?: Integration };
+	const { refreshIntegrations } = useDispatch( INTEGRATIONS_STORE ) as IntegrationsDispatch;


This file had an extra check for if Google was enabled using the useIntegrationStatus hook. Going forward, we'll want to use the new integrations store for single integrations checks like this too. The store allows for immediate checks without an extra endpoint call. You just check if a particular integration slug exists in the list of integrations. I've updated this file to do that. It also now uses the refreshIntegrations() method from the store.

dhasilva

LGTM! Tests well.

edanzer requested a review from a team October 3, 2025 20:39

edanzer self-assigned this Oct 3, 2025

edanzer added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] Normal [Package] Forms labels Oct 3, 2025

github-actions bot added the [Feature] Contact Form label Oct 3, 2025

github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Oct 3, 2025

edanzer marked this pull request as draft October 3, 2025 20:41

edanzer added the [Status] Needs Review This PR is ready for review. label Oct 3, 2025

github-actions bot added [Status] In Progress and removed [Status] Needs Review This PR is ready for review. labels Oct 3, 2025

edanzer commented Oct 3, 2025

View reviewed changes

edanzer force-pushed the add/forms-integrations-store branch 2 times, most recently from 6755420 to 4284278 Compare October 8, 2025 15:01

Base automatically changed from add/forms-integrations-store to trunk October 8, 2025 16:28

github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Oct 8, 2025

edanzer force-pushed the update/forms-google-enabled-check branch from df645af to b537f4a Compare October 8, 2025 16:33

edanzer changed the title ~~DO NOT MERGE Forms: Hide Google export if disabled~~ Forms: Hide Google export if disabled Oct 8, 2025

edanzer marked this pull request as ready for review October 8, 2025 16:37

edanzer changed the title ~~Forms: Hide Google export if disabled~~ Forms: Hide Google export card if disabled Oct 8, 2025

dhasilva approved these changes Oct 10, 2025

View reviewed changes

edanzer added 2 commits October 10, 2025 10:46

Forms: hide Google export if disabled

5effc02

changelog

2a8d326

edanzer force-pushed the update/forms-google-enabled-check branch from b537f4a to 2a8d326 Compare October 10, 2025 16:46

edanzer merged commit a92d969 into trunk Oct 10, 2025
67 checks passed

edanzer deleted the update/forms-google-enabled-check branch October 10, 2025 17:06

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 10, 2025

github-actions bot added this to the jetpack/15.2 milestone Oct 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: Hide Google export card if disabled #45375

Forms: Hide Google export card if disabled #45375

Uh oh!

edanzer commented Oct 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

edanzer Oct 3, 2025

Uh oh!

dhasilva left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Forms: Hide Google export card if disabled #45375

Forms: Hide Google export card if disabled #45375

Uh oh!

Conversation

edanzer commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

edanzer Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

dhasilva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

edanzer commented Oct 3, 2025 •

edited

Loading

github-actions bot commented Oct 3, 2025 •

edited

Loading

github-actions bot commented Oct 3, 2025 •

edited

Loading

jp-launch-control bot commented Oct 3, 2025 •

edited

Loading